Fix rendering of empty extra_fields
div
#542
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
On accounts with no extra fields defined, the containing div was still rendering.
Example:
![Screenshot 2024-09-06 at 8 00 59 PM](https://private-user-images.githubusercontent.com/28545431/365336311-f763b15d-fdb3-4bd4-996f-27f49168a06a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NjQwNDEsIm5iZiI6MTczOTU2Mzc0MSwicGF0aCI6Ii8yODU0NTQzMS8zNjUzMzYzMTEtZjc2M2IxNWQtZmRiMy00YmQ0LTk5NmYtMjdmNDkxNjhhMDZhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDIwMDkwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJjNDIyMzY4NWFiM2Q4NWI5YTAxNWQzYjdmYmUxYjk2ODg2NDMyNDRkZTVhOTlhOGFkNGY0MjUyOTA0MzVmMzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.BDKVoM3smiKEq_QzZ_ybftoFdsntMIFy_eUEPnHRjL8)
Fix:
In the original code, the if condition checked for defined labels and values, but the div still rendered even if no valid fields existed. Introduced
valid_fields
, a filtered list ofextra_fields
usingselectattr('value')
, which removes fields without valid values. This ensures only fields with both defined label and non-empty value are processed.Instead of just rendering the div based on the presence of any label/value, I added
valid_fields | length > 0
to check if any valid fields exist before rendering the div. This prevents rendering an empty div.Updated Screenshot:
![Screenshot 2024-09-06 at 8 04 21 PM](https://private-user-images.githubusercontent.com/28545431/365336456-f8275a86-e7e0-4597-876b-750e1ffec824.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NjQwNDEsIm5iZiI6MTczOTU2Mzc0MSwicGF0aCI6Ii8yODU0NTQzMS8zNjUzMzY0NTYtZjgyNzVhODYtZTdlMC00NTk3LTg3NmItNzUwZTFmZmVjODI0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDIwMDkwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU1NmE0MjU1ZjQ2ZDUyNzg5ZTNmZmE1ZjY2OGMyM2RkNDI0YmQzODE3MWMyNzExYTM5MTAzYmIwNWFkZTA5YWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.JDuWoynw5UcxbcYlU0eZBe3vLKzz5ewT_6yeouG2m04)